From d8d45223195aa16fce4fd8208e3ddedf7edf6a5c Mon Sep 17 00:00:00 2001
From: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date: Thu, 17 Aug 2023 21:30:39 -1000
Subject: [PATCH] CI: Enable MacOS Python Dev tests (#54587)

* CI: Enable MacOS Python Dev tests

* Build virtual environment

* Just use euo pipefail instead of l

* Revert "Just use euo pipefail instead of l"

This reverts commit 3552e7795ce69cd539c08ecc68d96bee8414b7e3.

* Don't use login shell for python dev

* Dont use virtual env

* Update .github/workflows/unit-tests.yml
---
 .github/workflows/unit-tests.yml | 31 +++++++++----------------------
 1 file changed, 9 insertions(+), 22 deletions(-)

diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml
index 66d8320206429..030c9546fecca 100644
--- a/.github/workflows/unit-tests.yml
+++ b/.github/workflows/unit-tests.yml
@@ -77,16 +77,12 @@ jobs:
             env_file: actions-311-numpydev.yaml
             pattern: "not slow and not network and not single_cpu"
             test_args: "-W error::DeprecationWarning -W error::FutureWarning"
-            # TODO(cython3): Re-enable once next-beta(after beta 1) comes out
-            # There are some warnings failing the build with -werror
-            pandas_ci: "0"
           - name: "Pyarrow Nightly"
             env_file: actions-311-pyarrownightly.yaml
             pattern: "not slow and not network and not single_cpu"
       fail-fast: false
     name: ${{ matrix.name || format('ubuntu-latest {0}', matrix.env_file) }}
     env:
-      ENV_FILE: ci/deps/${{ matrix.env_file }}
       PATTERN: ${{ matrix.pattern }}
       EXTRA_APT: ${{ matrix.extra_apt || '' }}
       LANG: ${{ matrix.lang || 'C.UTF-8' }}
@@ -150,14 +146,13 @@ jobs:
 
     - name: Generate extra locales
       # These extra locales will be available for locale.setlocale() calls in tests
-      run: |
-        sudo locale-gen ${{ matrix.extra_loc }}
+      run: sudo locale-gen ${{ matrix.extra_loc }}
       if: ${{ matrix.extra_loc }}
 
     - name: Set up Conda
       uses: ./.github/actions/setup-conda
       with:
-        environment-file: ${{ env.ENV_FILE }}
+        environment-file: ci/deps/${{ matrix.env_file }}
 
     - name: Build Pandas
       id: build
@@ -312,15 +307,14 @@ jobs:
     #    to the corresponding posix/windows-macos/sdist etc. workflows.
     # Feel free to modify this comment as necessary.
     #if: false # Uncomment this to freeze the workflow, comment it to unfreeze
+    defaults:
+      run:
+        shell: bash -eou pipefail {0}
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
       matrix:
-        # TODO: Disable macOS for now, Github Actions bug where python is not
-        # symlinked correctly to 3.12
-        # xref https://github.com/actions/setup-python/issues/701
-        #os: [ubuntu-22.04, macOS-latest, windows-latest]
-        os: [ubuntu-22.04, windows-latest]
+        os: [ubuntu-22.04, macOS-latest, windows-latest]
 
     timeout-minutes: 180
 
@@ -345,22 +339,15 @@ jobs:
         with:
           python-version: '3.12-dev'
 
-      - name: Install dependencies
+      - name: Build Environment
         run: |
           python --version
           python -m pip install --upgrade pip setuptools wheel meson[ninja]==1.0.1 meson-python==0.13.1
           python -m pip install --pre --extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple numpy
           python -m pip install versioneer[toml]
           python -m pip install python-dateutil pytz tzdata cython hypothesis>=6.46.1 pytest>=7.3.2 pytest-xdist>=2.2.0 pytest-cov pytest-asyncio>=0.17
-          python -m pip list
-
-      - name: Build Pandas
-        run: |
           python -m pip install -ve . --no-build-isolation --no-index
+          python -m pip list
 
-      - name: Build Version
-        run: |
-          python -c "import pandas; pandas.show_versions();"
-
-      - name: Test
+      - name: Run Tests
         uses: ./.github/actions/run-tests