Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remapping deletes duplicate classes from jars #104

Open
Juuxel opened this issue Oct 12, 2022 · 1 comment
Open

Remapping deletes duplicate classes from jars #104

Juuxel opened this issue Oct 12, 2022 · 1 comment

Comments

@Juuxel
Copy link
Member

Juuxel commented Oct 12, 2022

See example project: https://github.com/Juuxel/duplicate-mods

  • There are two mod dependencies, a.jar and b.jar
    • a.jar has classes A, B
    • b.jar has classes A, B, C, D
  • When you build the project with gradlew classes, Loom will remap the mods
  • If you take a look in .gradle/loom-cache/remapped_mods, only one of the jars will have the classes A, B even though both inputs have them

This is a simplified test case from a real-life mod setup where a crossplatform mod shadows some of its modules but still depends on the other modules in its POM.

@modmuss50
Copy link
Member

Fixing this requires a change on tiny remappers side of things. I will move this issue to that repo.

At the very least I think it should bail out in this case?

@modmuss50 modmuss50 transferred this issue from FabricMC/fabric-loom Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants