There can only be one definition for each target method

[Juuxel]

If the target method is defined multiple times, only the latest definition is taken into account and previous unpick data will be lost.

This is a slight problem in Yarn where we want to split Unpick files mostly by constant groups, and the same method might have multiple constant groups, so we have to put all categories into a longer file.

I think this is the cause (not 100% sure, just found this when digging around on GH):

unpick/src/main/java/daomephsta/unpick/impl/representations/TargetMethods.java

Line 128 in b07bc1a

parent.targetMethods.put(name + descriptor, new TargetMethod(owner, name, descriptor, parameterConstantGroups, returnConstantGroup));

The put call just ignores existing data.

[Daomephsta]

Just need to make it merge constant groups then

[apple502j]

Another related issue: unpick currently doesn't handle different methods with the same name and descriptor at all.

FabricMC/yarn#3114 unpicks three constructors of inner enums in GlStateManager: SrcFactor, DstFactor, and LogicOp - they all have the same descriptor <init>(Ljava/lang/String;II)V, so the last unpick definition overwrites the definition for the previous two.

Unlike the cases mentioned before, though, merging makes no sense here, as they are all separate methods.