Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objects move slightly after reset #443

Closed
reginald-mclean opened this issue Oct 4, 2023 · 2 comments · Fixed by #474
Closed

Objects move slightly after reset #443

reginald-mclean opened this issue Oct 4, 2023 · 2 comments · Fixed by #474

Comments

@reginald-mclean
Copy link
Collaborator

Currently the CI fails on one of the tests where the observation and goal are compared after sequential resets. After changing to MuJoco from mujoco-py it seems that there are a few environments where issues arise because objects aren't in exactly the same places after resets. The current fix is to replace len(np.unique(np.array(task_initial_pos), axis=0)) > 1 with len(np.unique(np.array(task_initial_pos), axis=0)) > 1 and not np.allclose( task_initial_pos[0], task_initial_pos[1], rtol=1e-2, atol=1e-2 ) but this masks the problem just to get the CI to pass

@reginald-mclean
Copy link
Collaborator Author

This may be because we need to add an extra mujoco.mj_forward(self.model, self.data) call to the reset/step functions.

@reginald-mclean
Copy link
Collaborator Author

reginald-mclean commented Apr 23, 2024

Fixed with PR #474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant