Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluation route choice + renaming references of "congestion" game to route_choice for consistency #58

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Evaluation route choice + renaming references of "congestion" game to route_choice for consistency #58

merged 5 commits into from
Jun 18, 2024

Conversation

hiazmani
Copy link
Collaborator

  • Training code for route choice environment
  • Renamed the "congestion game" environment (and relevant) files to route_choice for consistency

@hiazmani hiazmani requested review from rradules and ffelten May 30, 2024 13:23
ffelten
ffelten reviewed May 30, 2024
View reviewed changes
Copy link
Collaborator

@ffelten ffelten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to have a look under doc/, too. There surely are mentions to the old name.

momaland/learning/iql/iql.py Show resolved Hide resolved
rradules
rradules reviewed May 31, 2024
View reviewed changes
Copy link
Collaborator

@rradules rradules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for handling this. The modifications for the json networks were made to separate the reward signal?

@hiazmani hiazmani requested review from rradules and ffelten June 4, 2024 06:58
rradules
rradules approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@rradules rradules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@hiazmani
Copy link
Collaborator Author

hiazmani commented Jun 4, 2024

Nice, thanks for handling this. The modifications for the json networks were made to separate the reward signal?

The modifications in the JSON networks are to allow traffic to flow on both directions of each edge. The original graphs allow for agents to use an edge A-B to travel from A to B or from B to A. This doesn't change much in the smaller graphs (Braess) because no route ever uses the edges in the reversed direction, but it does for the larger (city-inspired) graphs. I added the latency function (which allows for computing the rewards) to the backlinks as well to allow this.

Also all the JSON files got "modified" according to Git because the parent directory got renamed from congestion to route_choice.

@rradules rradules merged commit 2be31ad into main Jun 18, 2024
10 checks passed
@rradules rradules deleted the evaluation_route_choice branch June 18, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffelten ffelten ffelten approved these changes

@rradules rradules rradules approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hiazmani @rradules @ffelten