Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The wishlistSets reducer is reseting the sets ids #878

Open
joaopedrofump opened this issue Oct 16, 2023 · 1 comment
Open

The wishlistSets reducer is reseting the sets ids #878

joaopedrofump opened this issue Oct 16, 2023 · 1 comment
Labels
status: accepted It's clear what the subject of the issue is about, and what the resolution should be type: bug Something isn't working properly

Comments

@joaopedrofump
Copy link

joaopedrofump commented Oct 16, 2023 •
edited
Loading

Expected behavior

The wihslistSets reducer should not reset the sets ids or at least should not reset the ones of the same user.

Actual behavior

The wihslistSets reducer is reseting the sets ids on action FETCH_WISHLIST_SUCCESS. This makes the useWishlistSets create extra network requests if we use useWishlistSets after useWishlist because the later triggers the action FETCH_WISHLIST_SUCCESS.

Steps to reproduce

  1. Anywhere, call useWishlist and then call useWishlistSets with a user with wishlist sets.
  2. Check the network for requests
  3. See that an extra network request is being made

Context/environment

Additional information

Possible fix
@joaopedrofump joaopedrofump added the type: bug Something isn't working properly label Oct 16, 2023
@boliveira
Copy link

Thank you @joaopedrofump, I acknowledge the bug and we will work on a fix. When we have it available, you will be notified.

@boliveira boliveira added the status: accepted It's clear what the subject of the issue is about, and what the resolution should be label Oct 16, 2023
@danielbento92 danielbento92 changed the title The wihslistSets reducer is reseting the sets ids The wishlistSets reducer is reseting the sets ids Oct 23, 2023
@boliveira boliveira mentioned this issue Nov 23, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepted It's clear what the subject of the issue is about, and what the resolution should be type: bug Something isn't working properly
Milestone
No milestone
Development

No branches or pull requests
2 participants
@boliveira @joaopedrofump