BeanDeserializerBase (2.6.0 regression): only update creatorProps with CreatorPropertys

[dharaburda]

It looks like the fix to issue [#795] introduced a bug as illustrated by the test case. An ArrayStoreException occurs when attempting to assign an ObjectIdReferenceProperty to the creatorProps array, understandably. Others have mentioned this on a similar (but I believe un-related) issue here and here.

Doing something like Arrays.copyOf(...) when the CreatorProperty array is returned from the value instantiator here prevents the ArrayStoreException but seems to cause downstream problems. Only updating creatorProps with an actual CreatorProperty seems reasonable to me but I am not super familiar with jackson internals.

[cowtowncoder]

Thank you for investigating this, proposing a fix. I agree in that the problem exists, but will need to see what are the consequences, and whether changing of type (of SettableProperty) would make most sense or not (that is, is CreatorProperty a true requirement).

I think the best way is probably for me to use the test case first, then work on verifying the fix.

[cowtowncoder]

Ok; I solved the problem in reverse way, by actually removing dependency to CreatorProperty for the most part; all tests now pass, including new one.
With 2.7 the property handling system is planned to be rewritten once again, since creator properties are currently merged too late for some annotations to take effect; but until then this will have to do.

[dharaburda]

Thanks once again for quick resolution -- looking forward to 2.6.1 😄

[cowtowncoder]

Thank you for reporting this and offering the patch!
Hoping to get 2.6.1 out quite soon as well -- a few issues reported, fixed, should allow much smoother upgrade from earlier versions.