Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test in the class BrokenSurrogatePair demonstrates an issue that appears to be rooted somewhere in the SMILE format. The byte array at the top includes a byte sequence that is outside the BMP (https://en.wikipedia.org/wiki/Plane_(Unicode)#Basic_Multilingual_Plane). There is no problem writing the value to a JSON node, but when trying to write it in SMILE format, the program crashes:
com.fasterxml.jackson.databind.JsonMappingException: Broken surrogate pair: first char 0xd92f, second 0x20; illegal combination
This branch isn't intended to fix this problem, just demonstrate its existence in the hopes that it can be more easily identified and fixed. Thanks!