Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant contains for String#replace #659

Open
Luro02 opened this issue Dec 17, 2024 · 0 comments
Open

Redundant contains for String#replace #659

Luro02 opened this issue Dec 17, 2024 · 0 comments
Labels
D-easy Easy to implement. enhancement New feature or request new-lint A new lint. unnecessary-complexity

Comments

@Luro02
Copy link
Collaborator

Luro02 commented Dec 17, 2024

What it does

It is redundant to check if something is in a string, before replacing it. If it is not there, it will not replace anything.

As a future extension: There might be other places where a contains is redundant, like for adding a value to a set?

Lint Name

REDUNDANT_CONTAINS

Category

complexity

Example

if (string.contains(word)) {
    result = string.replace(word, replacement);
}

Could be written as:

result = string.replace(word, replacement);
@Luro02 Luro02 added enhancement New feature or request new-lint A new lint. D-easy Easy to implement. unnecessary-complexity labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-easy Easy to implement. enhancement New feature or request new-lint A new lint. unnecessary-complexity
Projects
None yet
Development

No branches or pull requests

1 participant