Skip to content
This repository has been archived by the owner on Sep 8, 2023. It is now read-only.

Rewrite... again #105

Closed
TRIDENT1313 opened this issue May 24, 2023 · 3 comments
Closed

Rewrite... again #105

TRIDENT1313 opened this issue May 24, 2023 · 3 comments
Assignees

Comments

@TRIDENT1313
Copy link
Contributor

TRIDENT1313 commented May 24, 2023

So considering how much drama this thing has caused, I think a re-write might not be an awful idea.
When I considered how much they let us use, I want to reduce it down a ton, by half at least.

Bonus points if I can do it without breaking a persistent file.

Things that won't be changed:

  • Chat class thing (Too much work to re-do and will break everything.
  • Topic related stuff
  • Topic call

Things I'd like to re-do

  • Sky/weather
  • Rooms
  • Calendar (I want to make a new calendar. We have assets for it, so maybe I can do something with it.)
  • Backup system (I liked the backup system "we" had. If I can make another one, I might be able to prevent broken persistents with more ease)
  • Affection (Same rate of unlock, just a new class with new functions and do it... betterer

Maybes:

  • Chat class (granted this probably won't ever happen, but mayyyybeeee in future
  • Gifting but.. good (the way it is now... well it kinda sucks. I'd really like to make a proper gifting system with json files and all that, but parsing json is a pain in the ass.)
  • Time travel detection (Would be nice. Would add immersion. Will be frustrating to do.)

I think that covers just about everything.
I'll update this post as I think of more stuff

@TRIDENT1313 TRIDENT1313 self-assigned this May 24, 2023
@TRIDENT1313 TRIDENT1313 pinned this issue May 24, 2023
@Blizzardsev
Copy link
Collaborator

Blizzardsev commented Jun 20, 2023

A little late to the party so I apologize, but some thoughts.

I would personally struggle to see the value of a re-write here: FaE already has permissions for the systems in use after all, so reinventing the wheel on those for the sake of a situation that has already been resolved doesn't seem like grounds for effectively starting over on core mechanics - and from a third party perspective, I can see it being wasteful to have gone over the review process, etc. if the work taken wasn't going to be used anyway.

I think it's worth bearing in mind too that:

  • These systems are tried and tested, with most issues already ironed out - the investment for these in terms of dev time and testing has already been paid too! Why pay the same costs twice?
  • These systems will be a known quantity to potential contributors from other mods: switching to brand new systems means potential contributors having to learn even more bespoke code, and onboarding these kinds of projects can already be tricky.
  • Bugs already seem to be a challenge for FaE: is a rewrite for the reasons you gave worth the risk of more?
  • How will data be transferred from system to system? Does FaE have migration systems to handle this sort of thing?

Of course I'm not saying there isn't room for improvement with these systems, but I'd highly suggest rethinking this one before going neck-deep into changes. Remember, all the effort spent on something like this is time and energy that could be spent building up instead of starting again!

@TRIDENT1313
Copy link
Contributor Author

Adding on to my list of stuff to do.
Make a disclaimer on startup that this mod is not a substitute for a real relationship.
Too many people need to go outside and get away from the box that draws triangle very quickly.

I don't want our userbase to become as mentally ill as other mods of a similar caliber (across multiple communities I might add)

@ForeverAndEverTeam ForeverAndEverTeam deleted a comment from ashyashton Jul 21, 2023
@TRIDENT1313
Copy link
Contributor Author

This ain't happening and I guess it was foolish to think it would...

Maybe if someone else does their own Just Sayori mod, they can re-write it.

Anyway, closing.

@TRIDENT1313 TRIDENT1313 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants