Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: add checkbox toggle/bool notekind param type #3989

Open
2 tasks done
cyn0x8 opened this issue Jan 11, 2025 · 3 comments
Open
2 tasks done

Enhancement: add checkbox toggle/bool notekind param type #3989

cyn0x8 opened this issue Jan 11, 2025 · 3 comments
Labels
status: pending pull request Dependent on a pull request that is currently awaiting review. type: enhancement Involves an enhancement or new feature.

Comments

@cyn0x8
Copy link
Contributor

cyn0x8 commented Jan 11, 2025

Issue Checklist

  • I have properly named my enhancement
  • I have checked the Issues/Discussions pages to see if my enhancement has already been suggested

What is your suggestion, and why should it be implemented?

self explanatory

Image

@cyn0x8 cyn0x8 added status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature. labels Jan 11, 2025
@lemz1
Copy link
Contributor

lemz1 commented Jan 12, 2025

In #2635 this is added.
Here's the reference

enum abstract SongNoteFieldType(String) from String to String
{
  /**
   * The STRING type will display as a text field.
   */
  var STRING = "string";

  /**
   * The INTEGER type will display as a text field that only accepts numbers.
   */
  var INTEGER = "integer";

  /**
   * The FLOAT type will display as a text field that only accepts numbers.
   */
  var FLOAT = "float";

  /**
   * The BOOL type will display as a checkbox.
   */
  var BOOL = "bool";

  /**
   * The ENUM type will display as a dropdown.
   * Make sure to specify the `keys` field in the schema.
   */
  var ENUM = "enum";
}

@cyn0x8
Copy link
Contributor Author

cyn0x8 commented Jan 12, 2025

In #2635 this is added. Here's the reference

enum abstract SongNoteFieldType(String) from String to String
{
/**

  • The STRING type will display as a text field.
    */
    var STRING = "string";

/**

  • The INTEGER type will display as a text field that only accepts numbers.
    */
    var INTEGER = "integer";

/**

  • The FLOAT type will display as a text field that only accepts numbers.
    */
    var FLOAT = "float";

/**

  • The BOOL type will display as a checkbox.
    */
    var BOOL = "bool";

/**

  • The ENUM type will display as a dropdown.
  • Make sure to specify the keys field in the schema.
    */
    var ENUM = "enum";
    }

awesome

@cyn0x8 cyn0x8 closed this as completed Jan 12, 2025
@Hundrec Hundrec added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. status: resolved The issue has been fixed or the suggestion has been implemented. status: pending pull request Dependent on a pull request that is currently awaiting review. and removed status: pending triage Awaiting review. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. status: resolved The issue has been fixed or the suggestion has been implemented. labels Jan 23, 2025
@Hundrec Hundrec reopened this Jan 23, 2025
@Hundrec
Copy link
Collaborator

Hundrec commented Jan 23, 2025

Not sure what's going on in #2635, but I'm reopening this issue because I'm not sure if it's implemented just yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending pull request Dependent on a pull request that is currently awaiting review. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

No branches or pull requests

3 participants