Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PlatformerCharacterAnimator.json #1023

Closed
wants to merge 2 commits into from
Closed

Update PlatformerCharacterAnimator.json #1023

wants to merge 2 commits into from

Conversation

TheGemDev
Copy link
Contributor

Add ledge grab animation

image

@TheGemDev
Update PlatformerCharacterAnimator.json
dc1d75f 
Add platform grab animation
@TheGemDev TheGemDev requested a review from a team as a code owner September 25, 2023 20:49
@TheGemDev TheGemDev marked this pull request as draft September 25, 2023 20:52
@TheGemDev TheGemDev marked this pull request as ready for review September 25, 2023 20:56
@D8H
Copy link
Contributor

D8H commented Sep 26, 2023

Thank you for submitting this update. It sounds like a good addition. I'll take a look.

@arthuro555 arthuro555 added 🔄 Extension update An update for an existing extension 🔍 Reviewed extension An extension that is to be reviewed in great detail before merging. labels Sep 28, 2023
@D8H
Copy link
Contributor

D8H commented Nov 2, 2023 •
edited
Loading

I made an example because I didn't find any on this PR.
https://www.dropbox.com/scl/fi/52rw5lu89pfa5l6gq1bq3/TestCharacterAnimator.zip?rlkey=6odm5nenm0pttn3zjuk8j05l2&dl=1

I changed some descriptions and found an issue (that I didn't try to fix). It seems that the character can flip when it's on the ledge.

@arthuro555 arthuro555 added the 👩‍💻 Waiting for original submitter changes Changes to the extension are needed before going forward with the submission label Dec 16, 2024
@arthuro555
Copy link
Member

This PR is looking dead, I'll close it, feel free to reopen if/when someone's getting back to it

@arthuro555 arthuro555 closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🔄 Extension update An update for an existing extension 🔍 Reviewed extension An extension that is to be reviewed in great detail before merging. 👩‍💻 Waiting for original submitter changes Changes to the extension are needed before going forward with the submission
Projects
Extensions review
Status: Rejected
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheGemDev @D8H @arthuro555