Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point inside 3D Object #1046

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 9, 2023

Description

This extension tests if the given point is inside the boundaries of a 3D object.

How to use the extension

Provide X-, Y- & Z-Coordinates to test against a 3D Object.
Returns True if the point is inside the given object boundaries.

Checklist

  • I've followed all of the best practices.
  • I confirm that this extension can be integrated to this GitHub repository, distributed and MIT licensed.
  • I am aware that the extension may be updated by anyone, and do not need my explicit consent to do so.

What tier of review do you aim for your extension?

Reviewed

Example file

PointInside3DObjectExample.zip

Extension file

PointInside3dObject.zip

@github-actions github-actions bot requested a review from a team as a code owner October 9, 2023 16:24
@github-actions github-actions bot added the ✨ New extension A new extension label Oct 9, 2023
@github-actions github-actions bot mentioned this pull request Oct 9, 2023
3 tasks
@D8H
Copy link
Contributor

D8H commented Oct 9, 2023

Thank you for submitting this extension.

I have some concerns:

  • Using the Z position and the depth will only work for boxes that are not rotated.
    • To handle models as a boxes, new expressions would need to be added to get the origin and center point of 3D models
    • To handle rotation, it needs a bit of trigonometry.
  • Event-based conditions can't pick objects, for now, it needs a bit of JS

In which use-cases do you see this extension being used?
For projectiles or clicks, I guess a raycast would be a better fit.

@VanCastar VanCastar mentioned this pull request Oct 13, 2023
3 tasks
@github-actions github-actions bot mentioned this pull request Oct 13, 2023
3 tasks
@VanCastar
Copy link

This extension is included in the collection of extensions called ToolsFor3D in #1050

@VegeTato VegeTato added the 🔍 Reviewed extension An extension that is to be reviewed in great detail before merging. label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ New extension A new extension 🔍 Reviewed extension An extension that is to be reviewed in great detail before merging.
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

3 participants