Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Community] [3D Tween] Fix typos descriptions #1055

Merged
merged 2 commits into from
Oct 16, 2023
Merged

[Community] [3D Tween] Fix typos descriptions #1055

merged 2 commits into from
Oct 16, 2023

Conversation

AlexandreSi
Copy link
Contributor

No description provided.

@AlexandreSi AlexandreSi requested a review from a team as a code owner October 16, 2023 15:50
@AlexandreSi
Copy link
Contributor Author

Also, I think that the ScaleVolume action should be fixed (sentence, description and fullName are the ones of the StretchZ action) but I was not sure what to write instead:

https://github.com/GDevelopApp/GDevelop-extensions/blob/main/extensions/community/Tween3D.json#L313-L318

@D8H
Copy link
Contributor

D8H commented Oct 16, 2023

Also, I think that the ScaleVolume action should be fixed (sentence, description and fullName are the ones of the StretchZ action) but I was not sure what to write instead

Actually, you saw them because you read the json directly, but ActionWithOperator functions are using the associated expression declaration. I must have started with an action, changed the type and copy-pasted it.

@D8H D8H changed the title Fix typos in Tween3D extension descriptions [Community] [3D Tween] Fix typos in Tween3D extension descriptions Oct 16, 2023
@D8H D8H changed the title [Community] [3D Tween] Fix typos in Tween3D extension descriptions [Community] [3D Tween] Fix typos descriptions Oct 16, 2023
@D8H D8H merged commit 3839eed into main Oct 16, 2023
1 check passed
@D8H D8H deleted the fix-typos branch October 16, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants