Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trails v2 #1061

Closed
wants to merge 1 commit into from
Closed

Trails v2 #1061

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 18, 2023

Description

This extension adds actions to draw trails with a shape painter by referencing a start point and an end point.

2023-10-15.20-47-52.mp4

How to use the extension

How can i give my player character a trail?

1- Add "Draw trails" behavior to a shape painter.
2- Make object variables with the object's old position.
3- After the object's movement event execute, call "Draw a trail" with the start point being the old position variables, and the end point being the current object's position.

Checklist

  • I've followed all of the best practices.
  • I confirm that this extension can be integrated to this GitHub repository, distributed and MIT licensed.
  • I am aware that the extension may be updated by anyone, and do not need my explicit consent to do so.

What tier of review do you aim for your extension?

Reviewed

Example file

KTrails.zip

Extension file

Trails.zip

@github-actions github-actions bot requested a review from a team as a code owner October 18, 2023 19:47
@github-actions github-actions bot added the ✨ New extension A new extension label Oct 18, 2023
@github-actions github-actions bot mentioned this pull request Oct 18, 2023
3 tasks
@D8H
Copy link
Contributor

D8H commented Oct 19, 2023

Why not update the existing PR? Is because you want a full review? If this is the case, please add this new version with a comment in the other PR, state that you are aiming for the reviewed list and I'll close this one.

The example seems broken, look like the case of functions was changed from another project.

@github-actions
Copy link
Contributor Author

❗ No updates found. Please check your file.

1 similar comment
@github-actions
Copy link
Contributor Author

❗ No updates found. Please check your file.

@Kennoir
Copy link
Contributor

Kennoir commented Oct 20, 2023

!update
KTrails.zip

@github-actions
Copy link
Contributor Author

❗ No updates found. Please check your file.

@Kennoir Kennoir mentioned this pull request Oct 20, 2023
3 tasks
@Kennoir
Copy link
Contributor

Kennoir commented Oct 20, 2023

I can't update the example file for some reason so i'll drop it here:
KTrails.zip

Mentioned the extension in #856

@D8H
Copy link
Contributor

D8H commented Oct 20, 2023

I can't update the example file for some reason so i'll drop it here: KTrails.zip

Mentioned the extension in #856

You can't update the PR with an example because this is an extension PR. The example can only be in a normal comment like you did.

@D8H
Copy link
Contributor

D8H commented Oct 20, 2023

Let's continue in the other PR

@D8H D8H closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ New extension A new extension
Projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

2 participants