Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reviewed] [Double click] Handle back and forward buttons #1075

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Neko-MB
Copy link

@Neko-MB Neko-MB commented Nov 5, 2023

Updated to work for GDevelop version 5.3 and up (hopefully) Also added "Back/Forward" buttons incase one use so with mouse.

Updated to work for GDevelop version 5.3 and up (hopefully)
Also added "Back/Forward" buttons incase one use so with mouse.
@Neko-MB Neko-MB requested a review from a team as a code owner November 5, 2023 21:14
@D8H
Copy link
Contributor

D8H commented Nov 5, 2023

Thank you for submitting an extension update.

Updated to work for GDevelop version 5.3

What do you mean? I tried the existing extension with GDevelop 5.3.180 and didn't see any issue compared to older released.

Also added "Back/Forward" buttons in case one use so with mouse.

Indeed, this extension was not updated when these 2 choices were added.
What do you think about using child-variables instead of duplicating the events 5 times?

Events should never be collapsed in extensions or examples.

These conditions can be used to check parameters values:

image

There is also an issue when the condition is used several times in the events. Only the first one is working.

image

Do you want to help solving this issue too? One solution could be to clear the state only at the end of events in this life-cycle function:

image

@D8H D8H changed the title Update DoubleClick.json [Reviewed] [Double click] Handle back and forward buttons Nov 5, 2023
@D8H D8H added 🔄 Extension update An update for an existing extension 🔍 Reviewed extension An extension that is to be reviewed in great detail before merging. labels Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔄 Extension update An update for an existing extension 🔍 Reviewed extension An extension that is to be reviewed in great detail before merging.
Projects
Status: Needs changes
Development

Successfully merging this pull request may close these issues.

2 participants