Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update][Flash and transition painter] #1437

Open
3 tasks done
VegeTato opened this issue Nov 18, 2024 · 4 comments
Open
3 tasks done

[Update][Flash and transition painter] #1437

VegeTato opened this issue Nov 18, 2024 · 4 comments
Labels
✨ New extension A new extension

Comments

@VegeTato
Copy link
Contributor

VegeTato commented Nov 18, 2024

Description

  • Fixed the bug where the opacity was stuck at 150-200 rather than 255 while the transition is happening.
  • Added the original author name to the extension (Westboy).

How to use the extension

No response

Checklist

  • I've followed all of the best practices.
  • I confirm that this extension can be integrated to this GitHub repository, distributed and MIT licensed.
  • I am aware that the extension may be updated by anyone, and do not need my explicit consent to do so.

What tier of review do you aim for your extension?

Reviewed

Example file

Example.zip

Extension file

FlashTransitionPainter.zip

@VegeTato VegeTato added the ✨ New extension A new extension label Nov 18, 2024
Copy link
Contributor

👋 Thanks for your submission! We are sorry, but it seems we already have a reviewed extension with that name. Extensions cannot be in both the community and reviewed extensions list at once. If you are trying to update that extension, please ask a member of the extension team for help. If the name clash is a coincidence, please update your original submission post with a new zip file containing your extension with a file name that is not already taken 🙏

2 similar comments
Copy link
Contributor

👋 Thanks for your submission! We are sorry, but it seems we already have a reviewed extension with that name. Extensions cannot be in both the community and reviewed extensions list at once. If you are trying to update that extension, please ask a member of the extension team for help. If the name clash is a coincidence, please update your original submission post with a new zip file containing your extension with a file name that is not already taken 🙏

Copy link
Contributor

👋 Thanks for your submission! We are sorry, but it seems we already have a reviewed extension with that name. Extensions cannot be in both the community and reviewed extensions list at once. If you are trying to update that extension, please ask a member of the extension team for help. If the name clash is a coincidence, please update your original submission post with a new zip file containing your extension with a file name that is not already taken 🙏

@D8H
Copy link
Contributor

D8H commented Nov 18, 2024

Thank you for submitting a fix.

It was not the right way to fix the issue as the stacking of transparent shapes was to smooth the edges. Stacking 5 shapes with full opacity was defeating the purpose.
That said, it was not an efficient way to smooth the transition as a blur effect does a better and more efficient job:

  • A shader is probably more efficient than drawing a shape 5 times.
  • Users can configure the effect to get the smoothness that fits them.
  • Users can choose an opacity for the transition color (as there is no more stacking).
  • The events are simpler.

The new fix is here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ New extension A new extension
Projects
None yet
Development

No branches or pull requests

2 participants