Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDTranslator ISO to DCAT-US end-to-end test fixes #5046

Open
1 task
jbrown-xentity opened this issue Jan 23, 2025 · 1 comment
Open
1 task

MDTranslator ISO to DCAT-US end-to-end test fixes #5046

jbrown-xentity opened this issue Jan 23, 2025 · 1 comment
Labels
H2.0/Harvest-Transform Transform Logic for Harvesting 2.0

Comments

@jbrown-xentity
Copy link
Contributor

User Story

In order to make sure base use cases are covered, data.gov admins want a complete end-to-end test fixed for ISO to DCAT-US.

Acceptance Criteria

[ACs should be clearly demoable/verifiable whenever possible. Try specifying them using BDD.]

  • GIVEN the development work is complete
    WHEN the tests are run for MDTranslator
    THEN any items that aren't mapping in our default/best case scenario then an error is thrown.

Background

Related to analysis performed by metadata experts: https://drive.google.com/drive/u/1/folders/120R3ORnEvF1QFG4IuWch43H8WELtajFA

Security Considerations (required)

None

Sketch

There is already an end-to-end test in place: https://github.com/GSA/mdTranslator/blob/master/test/translator/tc_iso19115_2_datagov_to_dcatus.rb
Some tests are commented out, and probably relate to what is in the spreadsheet.
Ideally we should take a copy of the spreadsheet and work through what is addressed, commit by commit.

This might involve cleaning up our real world example to make it an "ideal" example.

@jbrown-xentity jbrown-xentity added the H2.0/Harvest-Transform Transform Logic for Harvesting 2.0 label Jan 23, 2025
@Bagesary Bagesary moved this to 📥 Queue in data.gov team board Jan 23, 2025
@rshewitt
Copy link
Contributor

rshewitt commented Jan 24, 2025

mapping doc

field test notes complete
title test ✔️
description test confirm with Liam
modified test uses xml path 2 confirm with Liam
publisher > name test ✔️
publisher > subOrganizationOf test TODO: revisit
contactPoint > hasEmail test TODO: revisit
identifier test uses xml path 4 confirm with Liam
accessLevel test ✔️
bureauCode no action needed ✔️
programCode no action needed ✔️
license test ✔️
rights test TODO: confirm this
spatial test ✔️
temporal test ✔️
accrualPeriodicity test confirm with Liam
conformsTo no action needed ✔️
dataQuality no action needed ✔️
describedBy test TODO: double check
describedByType test TODO: double check
isPartOf test confirm with Liam
issued test ✔️
language test TODO: update readme confirm with Liam
landingPage test uses xml path 4 confirm with Liam
primaryITInvestmentUII test TODO: update readme confirm with Liam
references test uses xml path 1. TODO: revisit confirm with Liam
systemOfRecords test TODO: update readme confirm with Liam
theme test ✔️
Dataset Distribution Fields no action needed ✔️
accessURL not in iso or dcatus ✔️
conformsTo not in iso or dcatus ✔️
distribution > description handled by distribution
distribution > downloadURL handled by distribution ✔️
format value is used in mediaType. TODO: revisit
mediaType TODO: revisit
distribution > title handled by distribution ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
H2.0/Harvest-Transform Transform Logic for Harvesting 2.0
Projects
Status: 📥 Queue
Development

No branches or pull requests

2 participants