Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support displaying cropped images with focal points #576

Closed
bertob opened this issue Oct 1, 2023 · 5 comments · Fixed by #1129
Closed

Support displaying cropped images with focal points #576

bertob opened this issue Oct 1, 2023 · 5 comments · Fixed by #1129
Labels
enhancement New feature or request status Status widget related issue

Comments

@bertob
Copy link
Contributor

bertob commented Oct 1, 2023

On the official web app you can set a focal point for images, which is cool to draw attention to specific parts of the image when it's cropped (e.g. in this case the top part is more interesting than the center):

image

@nekohayo
Copy link

Yup, that's issue #173 which also has some technical reference details ;)

@GeopJr
Copy link
Owner

GeopJr commented Oct 16, 2023

I'll split them into two issues, this one about displaying them and the other one about setting them since they are different implementation wise.

The main issue with implementing this is that Gtk.Picture is sealed (cannot be subclassed) so the only way to change the way the image is displayed (outside of the predefined options (cover, content fit etc)) is by re-creating Gtk.Picture from scratch (or at least that's my understanding of the situation)

@bertob
Copy link
Contributor Author

bertob commented Oct 30, 2023

outside of the predefined options (cover, content fit etc)

Might be worth filing a GTK issue asking if this could be in scope to be added to GtkPicture in the future?

@GeopJr
Copy link
Owner

GeopJr commented Nov 1, 2023

I'll investigate our other GtkPicture needs further first to see if we actually do need more than GtkPicture can provide (specifically, sizing/aspect ratio (#180), animated images (#196, #435) (I believe the aspect ratio one does require more control over the widget))

@nekohayo
Copy link

I'd suggest retitling this ticket to "Support displaying cropped images with focal points" to avoid confusion with the editing part (#173).

@GeopJr GeopJr changed the title Support image focual points Support displaying cropped images with focal points Nov 24, 2023
@GeopJr GeopJr added enhancement New feature or request status Status widget related issue labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request status Status widget related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants