Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two UndefVarErrors #8

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Fix two UndefVarErrors #8

merged 1 commit into from
Mar 15, 2024

Conversation

jaakkor2
Copy link
Contributor

Fix for these

using GLTF
o = GLTF.OcclusionTextureInfo()
o.strength = 0.1f0

gives

ERROR: UndefVarError: `strength` not defined
Stacktrace:
 [1] setproperty!(obj::GLTF.OcclusionTextureInfo, sym::Symbol, x::Float32)
   @ GLTF C:\Users\jaakkor2\.julia\packages\GLTF\t9Xw9\src\material.jl:99
 [2] top-level scope
   @ REPL[5]:1

and

using GLTF
p = GLTF.PBRMetallicRoughness()
p.roughnessFactor = 0.1f0

gives

ERROR: UndefVarError: `roughnessFactor` not defined
Stacktrace:
 [1] setproperty!(obj::GLTF.PBRMetallicRoughness, sym::Symbol, x::Float32)
   @ GLTF C:\Users\jaakkor2\.julia\packages\GLTF\t9Xw9\src\material.jl:144
 [2] top-level scope
   @ REPL[3]:1

@jaakkor2
Copy link
Contributor Author

Ping @Gnimuc

@Gnimuc Gnimuc merged commit 34fad88 into Gnimuc:master Mar 15, 2024
8 of 12 checks passed
@Gnimuc
Copy link
Owner

Gnimuc commented Mar 15, 2024

Thanks!

@jaakkor2 jaakkor2 deleted the undefvarsfix branch March 15, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants