Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpServletRequest#getServerName always returns 0.0.0.0 when using new performant HTTP connector #325

Open
ryantgraham opened this issue Dec 17, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@ryantgraham
Copy link

We've found what we believe to be an issue where calls to HttpServletRequest#getServerName when the new performant HTTP connector has been enabled is returning a different value when it is not enabled.

With the connector not enabled the value would be along the lines of:
{version}.appspot.com
image

With the connector enabled it always returns:
0.0.0.0
image

This can be reproduced using the Google App Engine Standard Environment Samples for Java 17 Bundled Services sample application and logging the output of the call to HttpServletRequest#getServerName in one of the servlets.

@ludoch ludoch added the bug Something isn't working label Dec 17, 2024
@ludoch
Copy link
Collaborator

ludoch commented Dec 17, 2024

Thanks for the report.

Maybe a regression in

via a9e0ea5 ?

@maigovannon
Copy link
Collaborator

@ludoch I think the issue might be the right one a54e790 since the a9e0ea5 was a field change.

@lachlan-roberts
Copy link
Collaborator

Yes looks like its from #311.

I will open a PR to fix the issue and increase the coverage from the test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants