Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin should support completing class alias #98

Open
cedricziel opened this issue Nov 28, 2017 · 0 comments
Open

Plugin should support completing class alias #98

cedricziel opened this issue Nov 28, 2017 · 0 comments

Comments

@cedricziel
Copy link
Collaborator

When a UseImportOption maps a concrete class to an alias, the plugin should autocomplete on it.

Example:

ClassName is TYPO3\CMS\Extbase\Annotation\Inject, alias is inject. What we need, is completion for lowercase @inject. I know this seems a bit clunky since we can alias an annotation to almost anything, but TYPO3 CMS recently introduced doctrine annotations and to minimize the impact, the current best-practice is to alias the new Inject Annotation to the old @inject phpDoc tag.

Currently, the completion provider completes the Annotation since there's nothing special, but when selected, it imports the annotation as specified (use TYPO3\CMS\Extbase\Annotation\Inject as inject) then inserts @Inject (which is not the correct value in this case) and then, to make it even worse, imports the Inject class once again. Sigh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant