Improve shelling out to brew
#1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
force-pushed
the
use_original_brew
branch
from
37e8846 to
5cd67a1
Compare
Bo98
approved these changes
Jan 6, 2025
colindean
approved these changes
Jan 6, 2025
jacobbednarz
approved these changes
Jan 6, 2025
Yea, I wonder if we should try replacing |
Good idea, will take a look at that. |
I already have a branch that does something like this, FYI. |
MikeMcQuaid
added a commit
to Homebrew/brew
that referenced
this pull request
Jan 7, 2025
Allow the ability for a system administrator to use `HOMEBREW_BREW_WRAPPER` and `HOMEBREW_FORCE_BREW_WRAPPER` variables to enforce the usage of a particular `brew` command for non-trivial (e.g. `brew --prefix` is considered trivial, it doesn't need to write to the prefix) Homebrew commands. This also introduces a `HOMEBREW_ORIGINAL_BREW_FILE` variable for some internal usage; `HOMEBREW_BREW_FILE` was being used internally for both "how should we shell out to Homebrew" and "what should we use to check permissions on Homebrew". `HOMEBREW_ORIGINAL_BREW_FILE` is now used just for the latter case. Inspired by conversation in Homebrew/homebrew-bundle#1551 which suggested this was worth fixing in wider than just `brew bundle`.
|
Closing in favour of Homebrew/brew#19049 |
Add a `Bundle.brew` helper to DRY things up a bit.
MikeMcQuaid
force-pushed
the
use_original_brew
branch
from
5cd67a1 to
1310c69
Compare
|
Actually, repurposed the refactoring here to make it a no-op and just DRY things up a bit. |
MikeMcQuaid
added a commit
to Homebrew/brew
that referenced
this pull request
Jan 7, 2025
Allow the ability for a system administrator to use `HOMEBREW_BREW_WRAPPER` and `HOMEBREW_FORCE_BREW_WRAPPER` variables to enforce the usage of a particular `brew` command for non-trivial (e.g. `brew --prefix` is considered trivial, it doesn't need to write to the prefix) Homebrew commands. This also introduces a `HOMEBREW_ORIGINAL_BREW_FILE` variable for some internal usage; `HOMEBREW_BREW_FILE` was being used internally for both "how should we shell out to Homebrew" and "what should we use to check permissions on Homebrew". `HOMEBREW_ORIGINAL_BREW_FILE` is now used just for the latter case. Inspired by conversation in Homebrew/homebrew-bundle#1551 which suggested this was worth fixing in wider than just `brew bundle`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
Bundle.brewhelper to DRY things up a bit.