Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "uniqueItems: true" to certain array fields in matrix.json #1465

Open
JoshuaFortriede opened this issue May 23, 2022 · 0 comments
Open
Labels
content Any PR that incorporates changes to the schema

Comments

@JoshuaFortriede
Copy link

For which schema is a change/update being suggested?

Matrix.json (module/protocol/matrix.json)

What should the change/update be?

For the fields "data_normalization_methods" and "derivation_process", add the jsonschema field "uniqueItems" and set it to a value of true.

This update constitutes a major change to the schema(s) it affects.

What new field(s) need to be changed/added?

None

Why is the change requested?

This change provides 2 uses. First, it ensures that the values in these arrays have no duplicates; these arrays should be unique and there should be no reason for the same value being present twice. Second, as groups create implementation layers, a "uniqueItems" value of "true" produces different UI elements (checkboxes instead of dropdown arrays).

While I understand implementation should be kept separate, I do believe there is a data standards reason for this change, and that change will also assist more usable UI implementations.

Other Considerations
It is quite possible that this jsonschema field (uniqueItems) should be used elsewhere in the HCA metadata schema.

@JoshuaFortriede JoshuaFortriede added the content Any PR that incorporates changes to the schema label May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Any PR that incorporates changes to the schema
Projects
None yet
Development

No branches or pull requests

1 participant