Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Add Portfolio to Overlay #1112

Merged
merged 19 commits into from
Oct 18, 2024
Merged

[Feat] Add Portfolio to Overlay #1112

merged 19 commits into from
Oct 18, 2024

Conversation

BrettCleary
Copy link
Collaborator

@BrettCleary BrettCleary commented Oct 16, 2024 •
edited
Loading

Summary

Add mm portfolio to overlay

Testing

https://app.qase.io/case/HC-371

@BrettCleary BrettCleary self-assigned this Oct 16, 2024
flavioislima
flavioislima approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@flavioislima
Copy link
Contributor

recheck

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@BrettCleary
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@BrettCleary
Copy link
Collaborator Author

recheck

Base automatically changed from feat/add_overlay_nav_bar to main October 16, 2024 19:57
@BrettCleary BrettCleary added the PR: Ready-For-Test PR is ready to be tested by a QA label Oct 17, 2024
nyghtstalker
nyghtstalker approved these changes Oct 17, 2024
View reviewed changes
Copy link

@nyghtstalker nyghtstalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed I am seeing the Portfolio option in the overlay and tested a lot of the options within it. Great job!

image
image

@BrettCleary BrettCleary merged commit da2f692 into main Oct 18, 2024
10 checks passed
@BrettCleary BrettCleary deleted the feat/add_overlay_tabs branch October 18, 2024 07:19
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nyghtstalker nyghtstalker nyghtstalker approved these changes

@eliobricenov eliobricenov eliobricenov approved these changes

@flavioislima flavioislima flavioislima approved these changes

Assignees

@BrettCleary BrettCleary

Labels
PR: Ready-For-Test PR is ready to be tested by a QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BrettCleary @flavioislima @eliobricenov @nyghtstalker