Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Don't show access code on mod dialog if no access code required #1206

Merged
merged 5 commits into from
Jan 14, 2025
Merged

[bug] Don't show access code on mod dialog if no access code required #1206

merged 5 commits into from
Jan 14, 2025

Conversation

jiyuu-jin
Copy link
Contributor

<--- Put the description here --->

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@jiyuu-jin jiyuu-jin added the Severity: 3 - Low Minimal impact, typically cosmetic issues or minor bugs affecting a few users. label Jan 7, 2025
@jiyuu-jin jiyuu-jin self-assigned this Jan 7, 2025
flavioislima
flavioislima approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

@jiyuu-jin
Copy link
Contributor Author

Tested with CI build on Mac

image

@BrettCleary BrettCleary added the PR: Ready-For-Test PR is ready to be tested by a QA label Jan 8, 2025
nyghtstalker
nyghtstalker approved these changes Jan 10, 2025
View reviewed changes
Copy link

@nyghtstalker nyghtstalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that I am no longer seeing the access code section (step 4) on the install modal for Market Wars.

image

@BrettCleary BrettCleary merged commit 68f7216 into main Jan 14, 2025
11 checks passed
@BrettCleary BrettCleary deleted the bug/hide-access-code-on-mod-install branch January 14, 2025 19:56
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nyghtstalker nyghtstalker nyghtstalker approved these changes

@eliobricenov eliobricenov eliobricenov approved these changes

@BrettCleary BrettCleary BrettCleary approved these changes

@flavioislima flavioislima flavioislima approved these changes

Assignees

@jiyuu-jin jiyuu-jin

Labels
PR: Ready-For-Test PR is ready to be tested by a QA Severity: 3 - Low Minimal impact, typically cosmetic issues or minor bugs affecting a few users.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jiyuu-jin @flavioislima @BrettCleary @eliobricenov @nyghtstalker