Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Replacing the collection concept with an entity-and-event-tagging concept #206

Open
johannesliem opened this issue Jun 1, 2023 · 0 comments

Comments

@johannesliem
Copy link
Member

johannesliem commented Jun 1, 2023

Why?

  • the current collection concept is confusing
  • if we introduce tags additional to collections it will be even more confusing - I think we can have either or

How

  • instead of multiple collections we have a single virtual collection which is constructed from derived state
  • entities and events are added to this collection by being tagged

How are tags managed?

Tags are defined and entities/events membership are stored in an intavia-tagging.slice

interface Tag {
    id: string;
    label: string;
    description: string;
    read-only: boolean; // true for tag that cannot be removed > e.g. on data import
    entities: Array<Entity['id']>
    events: Array<Event['id']>
}
interface ReverseEntityEventTagMap {
    entities: Record<Entity['id'], Array<Tag['id']>>
    events: Record<Event['id'], Array<Tag['id']>>
}

Initial State including reserved read-only "system-tags"

//TODO: define a list of system-tags

How, where and when are entities/events tagged?

Manually

  • selected entities or all entities of search result list (upstream or local)
  • manually created data in entity editor (user defined tags)
  • within data panel (user defined tags)

Automatically (read only)

  • "locally edited" tag for edited search results
  • xlsx template onImport ("imported"; one or more tags automatically given based on xlsx tab/worksheet name; other user defined tags replacing collections)
  • idm-json onImport ("imported" + user defined tags replacing collections)
  • manually created data ("created")
  • "inception" entities (created for events with id, label, relation in entity editor) ("new data/enrich-later/to-enrich")

How to create tags

Tag Widget?

Implications Collections Panel / Data Panel

  • we use tags to filter data in the panel (instead of the collections select)
  • tbd.
@johannesliem johannesliem changed the title Proposal: Moving from the collection concept to a single my-data-collection with entity-tagging-capabilities Proposal: Replacing the collection concept with an entity-and-event-tagging concept Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant