Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] - Node Release Notes Suggestions #6051

Open
Ranchhand87 opened this issue Dec 6, 2024 · 3 comments
Open

[FR] - Node Release Notes Suggestions #6051

Ranchhand87 opened this issue Dec 6, 2024 · 3 comments
Labels
needs triage Issue / PR needs to be triaged. type: enhancement An improvement on the existing functionality

Comments

@Ranchhand87
Copy link
Contributor

Ranchhand87 commented Dec 6, 2024

Original Source: https://docs.google.com/document/d/1Sf8HJNfdu-8equF991_NOaZE1vcJiN0fs6cy0z5G_Mg/edit?usp=sharing

Example mithril release notes: https://github.com/input-output-hk/mithril/releases/tag/2450.0

Cardano Node Release Notes Suggestions

Having the repos done in a manner in which we assume this is the first time a user has visited the repo will help document and provide all the needed info. As a small pool and an admin of the xSPO Alliance, an alliance for small pools under a million ada delegated when they join or for brand new pools, we receive a lot of questions that would be eliminated by better documentation on the repo. We see errors from using the wrong version on the network, to not updating config files correctly.

I believe the Mithril team and repo is the gold standard of how the repos should be done.

  • Suggestion 1
    Clear callout on what network node version is recommended to be used on.

Have a callout like Mithril does in release notes would great help so people don’t make a mistake

Also have a network Compatibility Chart right in repo

  • Suggestion 2
    Include in release notes if there is a configuration file change needed.

Also like Mithril does, they let us know if a configuration update is needed adding to repo would help as well.

  • Suggestion 3
    Have the versions listed right in repo
@Ranchhand87 Ranchhand87 added type: enhancement An improvement on the existing functionality needs triage Issue / PR needs to be triaged. labels Dec 6, 2024
@disassembler
Copy link
Contributor

disassembler commented Dec 18, 2024

My comments:

Suggestion 1: Agreed! We'll try to change the template to have this some time in Q1 next year
Suggestion 2: Would you like something like NEW after the link to the configuration files if there are any changes? We made the assumption people download configs from the book every release, but if people don't, I could see that being useful
Suggestion 3: Do you not like the collapsed list? Happy to remove all the collapses if they cause more harm than good. As engineers we thought hiding the details would draw people to the important information and users could epand the sections they care about. I'm open to getting rid of the collapses. It definitely makes the markdown uglier adding the details html tags everywhere to collapse things.

@disassembler disassembler changed the title [FR] - Node Repo Updates [FR] - Node Release Notes Suggestions Dec 18, 2024
@TerminadaPool
Copy link

I like the collapsed lists.

@btbf
Copy link

btbf commented Dec 19, 2024

I agree with all the suggestions, but a collapsed format would also be acceptable.

Additionally, it would be helpful if the presence or absence of DB replays is indicated for each lower version.

For example, in the case of 10.1.3:
9.2.1 or below : Required
10.1.1 or above: Not required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Issue / PR needs to be triaged. type: enhancement An improvement on the existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants