Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data backed constitution script #6784

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Conversation

ana-pantilie
Copy link
Contributor

@ana-pantilie ana-pantilie commented Jan 10, 2025

Fixes https://github.com/IntersectMBO/plutus-private/issues/1286

The performance is slightly worse in all of our benchmarks. They should be compared with the results in #6785, because master is not up to date.

@ana-pantilie ana-pantilie added the No Changelog Required Add this to skip the Changelog Check label Jan 10, 2025
@ana-pantilie ana-pantilie marked this pull request as ready for review January 10, 2025 14:53
@ana-pantilie ana-pantilie requested a review from a team January 10, 2025 14:55
Copy link
Member

@zliu41 zliu41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - the numbers are not bad at all!

Can you open an issue for reducing code duplication, especially in tests. It may be ok to duplicate the validator code for performance, but there's little reason to duplicate test code.

@bezirg
Copy link
Contributor

bezirg commented Jan 13, 2025

Looks great - the numbers are not bad at all!

Yes the results look very good and what I was expecting them to be.

Nothing -> BI.unitval -- this is a treasury withdrawal, we just accept it
{-# INLINABLE withChangedParams #-}

validateParamValue :: ParamValue -> BuiltinData -> Bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think validateParamValue can be imported from NonData.Common since it seems to be the same

@ana-pantilie ana-pantilie enabled auto-merge (squash) January 14, 2025 12:35
@ana-pantilie ana-pantilie merged commit 5266419 into master Jan 14, 2025
8 checks passed
@ana-pantilie ana-pantilie deleted the ana/data-backed-constitution-ver2 branch January 14, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Changelog Required Add this to skip the Changelog Check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants