-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data backed constitution script #6784
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - the numbers are not bad at all!
Can you open an issue for reducing code duplication, especially in tests. It may be ok to duplicate the validator code for performance, but there's little reason to duplicate test code.
Yes the results look very good and what I was expecting them to be. |
Nothing -> BI.unitval -- this is a treasury withdrawal, we just accept it | ||
{-# INLINABLE withChangedParams #-} | ||
|
||
validateParamValue :: ParamValue -> BuiltinData -> Bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think validateParamValue can be imported from NonData.Common since it seems to be the same
Fixes https://github.com/IntersectMBO/plutus-private/issues/1286
The performance is slightly worse in all of our benchmarks. They should be compared with the results in #6785, because master is not up to date.