Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Options are not updated by Loading #104

Open
buthanoid opened this issue Apr 4, 2022 · 0 comments
Open

Manual Options are not updated by Loading #104

buthanoid opened this issue Apr 4, 2022 · 0 comments

Comments

@buthanoid
Copy link
Member

buthanoid commented Apr 4, 2022

Problem

Manual options are not always updated. So you can end up with MiRA options and WISARD selected.

This is related to the fact that options are not persisted, which may be by itself a problem.

Scenario

  • Open OImaging
  • Select MiRA software
  • Observe that MiRA manual options have automatically been set
  • Load an OI Fits file
  • Observe that it set back to WISARD
  • Observe that MiRA manual options are still here. Problem!

Problem Process

The manual options are reset when you explicitly changes software from the GUI selection list.
The manual options are not reset when you load an OI Fits file that changes the software. They are not reset when you click on "Load Result as Input" button that changes the software.

Proposal

What about persisting the options in the OI Fits file ? This way the loading will load these options and set them in the model and the GUI.

A smaller solution that do not implement persistence would be to always reset to default software values before loading. Meaning, when you ask to load a file that will change software to SPARCO, it would first apply default SPARCO keywords values and manual options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant