Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github workflow to deploy to azure as static web app #215

Open
tobiasdiez opened this issue Oct 29, 2021 · 4 comments · Fixed by #216 · May be fixed by #306
Open

Add github workflow to deploy to azure as static web app #215

tobiasdiez opened this issue Oct 29, 2021 · 4 comments · Fixed by #216 · May be fixed by #306
Assignees
@tobiasdiez
Labels
p4: important type: developer experience

Comments

@tobiasdiez
Copy link
Member

@mohit038 could you please add a workflow (as a PR, maybe using https://github.com/JabRef/JabRefOnline/blob/main/.github/workflows/deploy.yml as a basis and incorporating JabRef/JabRefOnline#577). Then I will handle the necessary config in azure and add the secrets to github.
@tobiasdiez tobiasdiez mentioned this issue Oct 29, 2021
Closed
@tobiasdiez
Copy link
Member Author

I've configured everything on azures end, and added the deployment secret to github. The website is "live" at https://lively-ground-0d7c50410.azurestaticapps.net/

An example workflow can be found at https://docs.microsoft.com/en-us/azure/static-web-apps/build-configuration?tabs=github-actions#build-configuration

@mohit038-zz mohit038-zz mentioned this issue Nov 1, 2021
Merged
@tobiasdiez tobiasdiez reopened this Nov 1, 2021
@tobiasdiez
Copy link
Member Author

PRs and main are published to azure, but both cannot be sideloaded at the moment. Some comments how this may be done: #216 (review)

@tobiasdiez tobiasdiez mentioned this issue Sep 15, 2022
Closed
@tobiasdiez tobiasdiez self-assigned this Apr 21, 2023
@tobiasdiez
Copy link
Member Author

It should also create a new static web app for each PR (since staging slots are limited to 3). Similar to
https://github.com/JabRef/JabRefOnline/blob/dfa3c0d8f162ab045c21f115866adaa8aa4fff49/.github/workflows/deploy.yml#L42-L56

@tobiasdiez tobiasdiez linked a pull request Apr 21, 2023 that will close this issue
Open
@tobiasdiez
Copy link
Member Author

tobiasdiez commented Apr 25, 2023 •
edited
Loading

Todo:

  • Fix sideloading
  • Create PR deployments
  • Recreate azure static web app with location in EU

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobiasdiez tobiasdiez

Labels
p4: important type: developer experience
Projects
None yet
Milestone
No milestone
1 participant
@tobiasdiez