-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: Expected reorderId to be a string. Instead got undefined #91
Comments
I'm hitting the same issue. Current released version of the npm package is |
The config / markup has changed a lot for v3. Are you following the new readme? https://github.com/JakeSidSmith/react-reorder/tree/rework#configuration |
Oh right, that makes sense. I just @JakeSidSmith : For production software, is it better to use v3 alpha, or |
Uhhh. Hard to say. Personally I'd go with v3, as if you are not using multiple lists (in v3 you can drag between lists) v3 has some bug fixes that are not in v2. Though there is a bug with the dragging between lists #78 (comment). |
OK, I'll give a shot at v3, thanks ! |
Just sorted that: https://github.com/JakeSidSmith/react-reorder/blob/master/README.md Great minds. 😛 |
Note: if using a component class / stateless component you will need to manually pass down the reorder props: #78 (comment) Will hopefully find a way to avoid this in the future. 😄 |
Ignore what I said about the multi-list bug, forgot I had merged this: #83 |
Just to confirm that v3 is working perfectly ! IMO this issue deserves to be Closed 🙂 |
Will do. 😀 |
Except that npm install react-reorder installs v3, while GitHub shows the v2 docs. |
NPM install always installs the latest version, which in this case is the alpha version. I may merge v3 as is to avoid confusion and continue work on it. https://medium.com/@mbostock/prereleases-and-npm-e778fc5e2420 |
I'm running into this issue and didn't find any information about it in the documentation.
I tried a lot of different configurations with the same result. When I add
reorderId='_id'
to my list of props, I lose the warning and a div is created, but nothing is inside.Reorder is added to my component this way:
import Reorder from 'react-reorder'
And in the render:
The text was updated successfully, but these errors were encountered: