-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audio stream 'visualImpaired' chosen instead of standard stream #15
Comments
Unfortunately, this one seems more challenging than #2, as PlexAPI doesn't appear to provide a boolean member or similar functionality for the @dekaidekai, do you have any suggestions on what could be done short of submitting a feature request to https://github.com/pkkid/python-plexapi for adding support for this attribute? (Tagging you since you devised the original solution for the |
Tracking issue: pkkid/python-plexapi#1494. Once this is implemented, I should be able to address this easily. |
I just realized this was for I’ve reached out to Jonny in the same issue I had made above to see if there’s a way to retrieve this information. If there is, I should have a fix out within the next day. |
#15 Hopefully helps with not choosing `visualImpaired` audio streams unless explicitly set (like commentary), right now it only checks for the term in `extendedDisplayTitle`, `displayTitle` and `title` as there doesn't seem to be a way to check for a `visualImpaired` attribute any. I honestly don't even know if this is going to work or not as I've been in a fog this whole week due to being sick, and I do not have any video examples myself to test against this.
@gotson Could you check if my latest |
Yeah my thoughts would be wait to get |
@dekaidekai Yeah, I’m currently waiting for a PR to get merged and for a release on the PlexAPI side as Jonny did end up making a PR for the attribute once we figured out the whole it was for audioStream and not SubtitleStream situation xD. The current change I implemented at the moment is more of a "hope it works for now" type of commit. I plan to improve it in the near future once things progress a bit more. 😅 I’m just hoping Gotson can get back to me soon enough so I can at least get some kind of confirmation of the current commit. |
@JourneyOver okay nice best of luck, and hope you feel better soon! Your hard work is always appreciated but remember feel free to do it at your own pace. Your health takes priority 🙏 |
would that be available as a Docker image ? |
@gotson Yes, that’s exactly what the |
nice, let me give it a try |
@JourneyOver you madman, that worked ! Thanks a lot. |
Great glad to hear! I'll be improving the code slightly in the future for this as well once pkkid/python-plexapi#1495 gets merged in and a release happens on PlexAPI side of things so I may ping you when that happens in the future to test it out, but I'm glad to hear at least my current solution is working. Since this is now fixed, I am going to be closing this issue for now. (I'm thinking of make an actual |
if you do please let me know, so i can move back to
no worries, would be happy to test |
@gotson I just pushed a new release so feel free to move back to |
Describe the bug
I have a show with 2 audio streams as follow:
To Reproduce
Select the "French (EAC3 Stereo)" stream.
Expected behavior
The "French (EAC3 Stereo)" is set for the whole series.
Actual Behavior
The "French Descriptive (AAC Stereo)" is set for the whole series.
Environment Details
Logs and Screenshots
The text was updated successfully, but these errors were encountered: