Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clean!(::Triangulation) and clean!(::VoronoiTessellation) (with better names) #116

Closed
DanielVandH opened this issue Jun 14, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@DanielVandH
Copy link
Member

DanielVandH commented Jun 14, 2024

These methods would redefine the connectivities and the point lists so that only points in the triangulation/tessellation are included in the connectivities. It would also remove any empty features like in https://github.com/JuliaGeometry/DelaunayTriangulation.jl/blob/d3bdb2e9d5518bf00748e26a1d28b745289ed082/src/algorithms/triangulation/basic_operations/clear_empty_features.jl

cc: @juliohm

@DanielVandH
Copy link
Member Author

Might not be able to do this in-place since not every users point set will be mutable. Maybe just make two methods repair and repair!, where repair will recreate the triangulation and make a new point set as a vector of tuples

@DanielVandH
Copy link
Member Author

Repair is a bad name incase I want to implement e.g. shewchuks repair algorithm for perturbed data

@DanielVandH DanielVandH added enhancement New feature or request good first issue Good for newcomers labels Jul 6, 2024
@DanielVandH DanielVandH changed the title Add repair!(::Triangulation) and repair!(::VoronoiTessellation) Add clean!(::Triangulation) and clean!(::VoronoiTessellation) (with better names) Jul 6, 2024
@JuliaGeometry JuliaGeometry locked and limited conversation to collaborators Jul 21, 2024
@DanielVandH DanielVandH converted this issue into discussion #150 Jul 21, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant