Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not store the dynamic modulus in complex form? #109

Open
akabla opened this issue Apr 11, 2021 · 3 comments
Open

Why not store the dynamic modulus in complex form? #109

akabla opened this issue Apr 11, 2021 · 3 comments
Assignees

Comments

@akabla
Copy link
Member

akabla commented Apr 11, 2021

I am wondering why we store the complete modulus split into its real and imaginary parts. Wouldn't it be better to work with the complex expressions? They are a bit simpler to write/read, and possibly more effective to compute too. Often the norm and phase are important too, and a complex representation may be more suitable. But maybe @moustachio-belvedere @Ab2425 you have good reasons to prefer the real/imag parts as separate functions?

@moustachio-belvedere
Copy link
Member

moustachio-belvedere commented Apr 17, 2021

Related to #35 perhaps both could be solved at the same time.

I think we decided that most people get their experimental data in that format. Also made it convenient for having the multi-objective cost function so elastic/viscous components can be weighted in a sensible way. This could also be done by splitting modulus/arg, or some other wrapper to split real/imaginary, but I think some careful evaluation is required on real-world data to see how it affects fitting. Computation efficiency, fitting accuracy, fitting flexibility probably all need evaluation.

@akabla
Copy link
Member Author

akabla commented Apr 17, 2021

I'd say that the loading of the experimental data is fairly independent of the internal storage and processing afterwards. We could easily convert one into the other when the files are loaded.

The expressions for G' and G'' are more complicated that the expressions for G as a complex variable, since that gets rid of many sin and cos in the expressions. Usually, we need both G' and G'' for fitting purposes. In this case, I suspect that it would be better to calculate the whole expression as a complex variable and extract the real and imag axes later on, for instance for the cost function. We may as well want to build a cost function based on the log modulus of G and the phase difference, maybe?

Another benefit of the complex variable is that they are more directly related to the diff equation and Laplace transform.

Let's do some tests at some point then, and keep this issue open as a reminder.

@moustachio-belvedere
Copy link
Member

To add though, I realised I did not mention enough the positive aspect of this. I think the complex form approach has a lot of potential, it could well yield excellent computational + readability + modulus definition benefits.

@moustachio-belvedere moustachio-belvedere removed their assignment Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants