Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking constraints on parameters in moduli functions #114

Open
akabla opened this issue Apr 17, 2021 · 0 comments
Open

Checking constraints on parameters in moduli functions #114

akabla opened this issue Apr 17, 2021 · 0 comments

Comments

@akabla
Copy link
Member

akabla commented Apr 17, 2021

We have some tests as part of the expressions themselves in the model declarations, and they are not always consistent with the constraint expressions. (Discussion stared as part of #111)

I suggest to remove the tests in the expressions of the moduli (unless that would cause terrible issues with other parts like NLopt) and rather make sure that we test parameters in functions such as relaxmod, creepcomp, etc., throwing an exception with explicit error message.

This is also related to #86.

The issue of the specilisation of models for certain parameters values might be worth considering here too. If a Springpot with exponent 0 is considered, should Rheos know that this is a Spring and use the specialised model instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant