Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong "No Error Handler" conversion #1868

Open
squakez opened this issue Dec 17, 2024 · 5 comments
Open

Wrong "No Error Handler" conversion #1868

squakez opened this issue Dec 17, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@squakez
Copy link

squakez commented Dec 17, 2024

Testing a simple Camel route with a "no error handler" is resolving in the following code:

- errorHandler: {}

However it seems this is wrong, as it doesn't run. The correct way to handle this seems to be:

- errorHandler:
    noErrorHandler: {}

Tested with Camel 4.9.0

@squakez squakez added the bug Something isn't working label Dec 17, 2024
@lordrip
Copy link
Member

lordrip commented Dec 17, 2024

Hi @squakez, thanks for raising this issue. What environment did you use? VS Code or the online version?

By default, when adding an errorHandler, it's not configured until you open the config panel and pick your desired errorHandler.

image

That being said, we could instantiate an errorHandler with noErrorHandler preselected, but I'm wondering what would be the difference between having noErrorHandler vs not having an errorHandler at all 😅

As far as I can see, in the online version, selecting noErrorHandler serializes
edit: I can reproduce it in the online version as well.

- errorHandler:
    noErrorHandler: {}

but it looks like it's not the case in VS Code

@lordrip
Copy link
Member

lordrip commented Dec 17, 2024

It seems it's the same situation for Ref Error Handler

@squakez
Copy link
Author

squakez commented Dec 18, 2024

Hello. I've used the online tool. I didn't test in VSCode.

@lordrip
Copy link
Member

lordrip commented Jan 7, 2025

We're gonna prepopulate the errorHandler with the defaultErrorHandler

@lordrip
Copy link
Member

lordrip commented Jan 7, 2025

Pending to check what would be the difference between:

  1. no errorHandler defined
  2. default errorHandler
  3. noErrorHandler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

2 participants