Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharesight problem - not handling Share Splits #266

Open
nsratcliffe opened this issue Sep 12, 2022 · 3 comments
Open

Sharesight problem - not handling Share Splits #266

nsratcliffe opened this issue Sep 12, 2022 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@nsratcliffe
Copy link

Hi there, After tweaking the formats (see previous issue) and using Google Sheets to save as .csv (don't download direct Excel from Sahresight !) I've not hit a problmem where a share I own has undergone a Split - so in the .csv file the a row has Split for the TYpe of action. cgt-calc throws up an error (Unknown action: Split). This is needed as without the split when I came to sell the shares cgt-calc threw an invalid transaction error as it thought I was trying to sell more shares than I owned. Can this be easily fixed?

@nsratcliffe
Copy link
Author

Hi there, After tweaking the formats (see previous issue) and using Google Sheets to save as .csv (don't download direct Excel from Sahresight !) I've not hit a problmem where a share I own has undergone a Split - so in the .csv file the a row has Split for the TYpe of action. cgt-calc throws up an error (Unknown action: Split). This is needed as without the split when I came to sell the shares cgt-calc threw an invalid transaction error as it thought I was trying to sell more shares than I owned. Can this be easily fixed?

BTW there are two other actions to handle in addition to Split that appear in the All Trades Report.csv : 1. Consolidation and 2. Bonus.

@vmartinv
Copy link
Collaborator

We need someone who uses sharesight to add support for these actions into the parser.

@deed02392
Copy link
Contributor

deed02392 commented Jan 24, 2024

The README mentions that this tool supports splits, but it's not documented. Looking at the source there seems to be support in the raw format for splits:

2022-06-06,STOCK_SPLIT,AMZN,209,0.00,0.00,USD

But then it looks as though they are still only handled for MSBB and there is only one split (for Google) which is hard-coded:

StockSplit(symbol="GOOG", date=datetime.datetime(2022, 6, 15).date(), factor=20),

@vmartinv vmartinv added the help wanted Extra attention is needed label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants