Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gating buttons position/size #74

Open
McCrea opened this issue Apr 1, 2014 · 4 comments
Open

Gating buttons position/size #74

McCrea opened this issue Apr 1, 2014 · 4 comments

Comments

@McCrea
Copy link
Member

McCrea commented Apr 1, 2014

Currently the buttons for creating gates, resetting the current tool and downloading the dataset seem pretty large. That also means they can either end up next to the graph or pushed below it, which seems messy to me.
I think we should reduce the size of the buttons (at least the reset/download buttons since they'll probably be used quite infrequently). We could then put the buttons directly below the graph in the same well, creating a sort of second toolbar. We could put options for inverse gating etc. in that toolbar too.
Any thoughts?

@McCrea McCrea added this to the Final milestone Apr 1, 2014
@mrudelle
Copy link
Member

mrudelle commented Apr 2, 2014

Let's keep in mind we want to ease the use on small screen, reducing the button size might do the opposite.

On 1 April 2014 23:41:06 GMT+01:00, Jack McCrea [email protected] wrote:

Currently the buttons for creating gates, resetting the current tool
and downloading the dataset seem pretty large. That also means they can
either end up next to the graph or pushed below it, which seems messy
to me.
I think we should reduce the size of the buttons (at least the
reset/download buttons since they'll probably be used quite
infrequently). We could then put the buttons directly below the graph
in the same well, creating a sort of second toolbar. We could put
options for inverse gating etc. in that toolbar too.
Any thoughts?


Reply to this email directly or view it on GitHub:
#74

Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

@hazeld
Copy link
Contributor

hazeld commented Apr 2, 2014

I like the idea of a toolbar below the graph for the buttons, I think we just need to make sure it could still be used easily on mobile.

@McCrea
Copy link
Member Author

McCrea commented Apr 2, 2014

I’m not thinking of making the buttons tiny just smaller.
Since we know that the buttons for opening/closing the file selector are large enough on mobile/tablet, going with a similar size would ensure they were small enough.

I think this could actually improve usability on all small-screened or low-resolution devices as it will reduce the likelihood of having to scroll down to create a gate.
It also means the buttons are always in the same place, which I personally think would be beneficial.
On 2 Apr 2014, at 11:25, Hazel Doughty [email protected] wrote:

I like the idea of a toolbar below the graph for the buttons, I think we just need to make sure it could still be used easily on mobile.


Reply to this email directly or view it on GitHub.

@McCrea McCrea self-assigned this Apr 3, 2014
@RoganMurley
Copy link
Contributor

I agree with this and think it would give the site a more consistent feel.

@McCrea McCrea removed their assignment Apr 30, 2014
samwisethetired added a commit that referenced this issue May 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants