From 692fbeec1b94d8ff66a82b9c3fe5d8242962750b Mon Sep 17 00:00:00 2001 From: Sidhant Kohli Date: Mon, 16 Sep 2024 23:52:54 -0700 Subject: [PATCH] fix: skip updating phase for resource check (#2065) Signed-off-by: Sidhant Kohli --- pkg/reconciler/pipeline/controller.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/reconciler/pipeline/controller.go b/pkg/reconciler/pipeline/controller.go index b2f99e7b1d..5776c2873c 100644 --- a/pkg/reconciler/pipeline/controller.go +++ b/pkg/reconciler/pipeline/controller.go @@ -610,7 +610,7 @@ func buildVertices(pl *dfv1.Pipeline) map[string]dfv1.Vertex { copyVertexTemplate(pl, vCopy) copyVertexLimits(pl, vCopy) replicas := int32(1) - // If the desired phase is pause or we are in the middle of pausing we should not start any vertex replicas + // If the desired phase is paused or we are in the middle of pausing we should not start any vertex replicas if isLifecycleChange(pl) { replicas = int32(0) } else if v.IsReduceUDF() { @@ -952,7 +952,7 @@ func (r *pipelineReconciler) checkChildrenResourceStatus(ctx context.Context, pi defer func() { for _, c := range pipeline.Status.Conditions { if c.Status != metav1.ConditionTrue { - pipeline.Status.SetPhase(pipeline.Spec.Lifecycle.GetDesiredPhase(), "Degraded: "+c.Message) + pipeline.Status.Message = "Degraded: " + c.Message return } }