You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Create a class AutomataKeys which only loads the FSA part and provides all key related methods, that's quite useful, also for indexer. Automata will then be a subclass adding the value related methods.
Create a class DictionaryGenerator which will provide the old generator functionality, meaning creating a keyvifile for pre-sorted input. The AddValue method on the old generator will be moved to this class. This will allow us to do the final cleanup of the different value store writers. LBNL lets turn the value store into a shared pointer, right now ownership is on the generator but it should really be shared ownership between the compiler and the generator.
I am not sure about the friend relationship. We need to get the raw pointer into the value store as a performance trick to speed up merging. This is very special and I consider it unsafe for normal usage, therefore I still think this friend relationship makes sense. Fortunately #93 removed most of the other friend relationships after the separation of mergers.
Implementation will provide following benefits:
The text was updated successfully, but these errors were encountered: