-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header versioning for compatibility with other components (as opposed to SPIR-V versioning) #167
Comments
[Edit: The following were my thoughts on using tags as a way of getting SPIRV-Tools compatability.] It would be far more successful to use top of master than to rely on a tag. If we tag often, how do you know which tag to use? It is the same problem of how to know which commit to use. Or, are you asking for a rule that the most recent tag here should always work with SPIRV-Tools? I'm not against making a tag, but I think we need some ground rules about what it means and when to do it, which in practice would operate successfully more often than top of master would work, but I'm unclear what those would actually be. Wouldn't it be better for SPIRV-Tools to say which commit they depend on in SPIRV-Headers? Don't they already do that with a dependency file? |
Why? Using tagged versions allows you as well to have some changes commuted which are still needs to be synced with other projects without affecting everything around. PS> BTW: SPIRV-Headers should offer as well pkgconfig .pc file which will allow detect is SPIRV-Headers installed or now and in which one version. If you want I try submit PR with that. |
This can be versioned too, I'm not saying no. I'm asking that, if we do version, how will you know which version is correct to use? To me, it seems the missing piece is knowing what the right one is, independent of whether it is a commit, a tag, or a more formal release. I think SPIRV-Tools must already say which commit it depends on, and that could be used, and everything would work. |
The same way as in case of SPIRV-Tools:
All what needs to be done is add SPIRV-headers.pc to this package similar to that one which is in SPIRV-Tools |
I added the tag We need to discuss internally the way to communicate which SPIRV-Headers is matched/tested with which other components (and which would be correct more often than simply selecting a recent commit). |
KhronosGroup/SPIRV-Tools#3647
The text was updated successfully, but these errors were encountered: