Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec change] Add sycl_khr_work_item_queries extension #1008

Open
sycl-issue-bot bot opened this issue Dec 16, 2024 · 1 comment
Open

[Spec change] Add sycl_khr_work_item_queries extension #1008

sycl-issue-bot bot opened this issue Dec 16, 2024 · 1 comment

Comments

@sycl-issue-bot
Copy link

Please review whether KhronosGroup/SYCL-Docs#682 by @Pennycook requires any changes to the CTS.

If changes are required: Open a new PR addressing the changes and link it to this issue.
If no changes are required: Close this issue and proceed with the spec PR.

@Pennycook
Copy link
Contributor

This change will require CTS changes.

Since these queries return instances of existing classes, it is probably sufficient to just test for equality:

q.parallel_for(sycl::nd_range<1>{1024}, [=](sycl::nd_item<1> it) {
  result[it.global_linear_id(0)] = (sycl::khr::this_work_item::get_nd_item<1>() == it);
});

...with equality tests for sycl::nd_item, sycl::group and sycl::sub_group, in one-, two- and three-dimensional kernels.

We don't have to test cases where the number of dimensions in the query don't match the number of dimensions in the kernel launch, because the behavior in that case is undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant