-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defining VULKAN_HPP_NO_EXCEPTIONS
when using C++ modules results in missing vk::raii
members
#1648
Comments
It seems that the |
This may or may not be related: #1498 |
You're absolutely right, this is related to #1498. |
What problems do you have with the example from the README.md? |
From the tip of my head I had to add all these lines: # find Vulkan SDK
find_package( Vulkan REQUIRED )
+target_compile_features("VulkanCppModule"
+ PUBLIC
+ cxx_std_23
+)
+target_include_directories("VulkanCppModule"
+ PRIVATE
+ "${Vulkan_INCLUDE_DIR}"
+)
+target_link_libraries("VulkanCppModule"
+ PUBLIC
+ "Vulkan::Vulkan"
+)
# set up Vulkan C++ module
add_library(VulkanCppModule)
-target_sources(VulkanCppModule PRIVATE
+ target_sources(VulkanCppModule PUBLIC
- FILE_SET CXX_MODULES
+ FILE_SET cxx_modules TYPE CXX_MODULES
+ BASE_DIRS "${Vulkan_INCLUDE_DIR}"
FILES ${Vulkan_INCLUDE_DIR}/vulkan.cppm
)
|
@asuessenbach Thank you for the quick reaction! |
I finally found the C++20 module sample and it add almost the same additional settings as mine setup above: Line 353 in 23606b2
Maybe the instructions on the README page need to be updated. |
Also the README recommends using https://github.com/microsoft/vcpkg/blob/master/ports/vulkan-hpp/usage |
I'm experimenting with the C++ module and I have created the following working setup (the example one in the README.md doesn't work):
Build errors:
The text was updated successfully, but these errors were encountered: