Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_string functions are massive and probably shouldn't always be inline. #1965

Open
Emimendoza opened this issue Oct 1, 2024 · 1 comment

Comments

@Emimendoza
Copy link

The to_string set of functions are quite large and since they are always inline, using them on multiple functions on multiple files explodes the binary size. It also makes it hard to debug if you use a de compiler as part of your debugging tools. I suggest changing the attributes to be a non inlined weakly declared/defined symbol instead. That way, during the linking step, only one of the symbols will be arbitrarily used and the rest of the duplicates will be discarded.

@asuessenbach
Copy link
Contributor

@Emimendoza That's an interesting aspect to keep in mind. We did some testing on that issue and it seems, those functions tend to not be inlined, but kept as separate functions. Probably due to their size.
Do you have some setup or program that produces multiple inlined instances of (some of) those functions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants