Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning during build - <ciso646> is deprecated in C++17 #2034

Open
heitbaum opened this issue Jan 6, 2025 · 2 comments
Open

Warning during build - <ciso646> is deprecated in C++17 #2034

heitbaum opened this issue Jan 6, 2025 · 2 comments

Comments

@heitbaum
Copy link

heitbaum commented Jan 6, 2025

Ref: https://en.cppreference.com/w/cpp/header/ciso646
Log:

$ g++ -v
gcc version 15.0.0 20250105 (experimental) (GCC)

…
[5/8] Building CXX object cube/CMakeFiles/vkcubepp.dir/cube.cpp.o
In file included from /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include/vulkan/vulkan_hpp_macros.hpp:35,
                 from /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include/vulkan/vulkan.hpp:11,
                 from ../cube/cube.cpp:51:
/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/x86_64-libreelec-linux-gnu/include/c++/15.0.0/ciso646:46:4: warning: #warning "<ciso646> is deprecated in C++17, use <version> to detect implementation-specific macros" [-Wcpp]
   46 | #  warning "<ciso646> is deprecated in C++17, use <version> to detect implementation-specific macros"
      |    ^~~~~~~
@charles-lunarg
Copy link

This looks to be a Vulkan-Hpp issue, rather than with the C++ Vulkan Header usage cube.cpp does. Moving accordingly.

@charles-lunarg charles-lunarg transferred this issue from KhronosGroup/Vulkan-Tools Jan 6, 2025
@asuessenbach
Copy link
Contributor

asuessenbach commented Jan 7, 2025

@heitbaum as your link above tells us, ciso646 is removed with C++20. It doesn't tell anything about a deprecation warning.
The replacing header version is available with C++20 (https://en.cppreference.com/w/cpp/header/version)
And with C++20, Vulkan-Hpp uses that version header:

// include headers holding feature-test macros
#if 20 <= VULKAN_HPP_CPP_VERSION
#  include <version>
#else
#  include <ciso646>
#endif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants