Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove misleading ICD/layer warnings #1632

Open
lunarpapillo opened this issue Jan 7, 2025 · 0 comments
Open

remove misleading ICD/layer warnings #1632

lunarpapillo opened this issue Jan 7, 2025 · 0 comments

Comments

@lunarpapillo
Copy link
Contributor

Windows11-ARM systems ship with six dzn layer and ICD files in the same directory:

 Directory of C:\Program Files\WindowsApps\microsoft.d3dmappinglayers_1.2409.2.0_arm64__8wekyb3d8bbwe

04/09/2024  11:38 AM               177 dzn_icd.arm64.json
04/09/2024  11:38 AM               175 dzn_icd.x64.json
04/09/2024  11:38 AM               175 dzn_icd.x86.json
07/16/2024  12:26 PM               452 dzn_layer.arm64.json
07/16/2024  12:26 PM               450 dzn_layer.x64.json
07/16/2024  12:26 PM               450 dzn_layer.x86.json

When the loader parses this, it gives warnings about the ICD manifests, that they don't contain a layer field, and warnings about the layer manifests, that they don't contain an ICD field, e.g.:

WARNING: [Loader Message] Code 0 : loader_add_layer_properties: Can not find 'layer' object in manifest JSON file C:\Program Files\WindowsApps\microsoft.d3dmappinglayers_1.2409.2.0_arm64__8wekyb3d8bbwe\dzn_icd.arm64.json.  Skipping this file.
WARNING: [Loader Message] Code 0 : loader_add_layer_properties: Can not find 'layer' object in manifest JSON file C:\Program Files\WindowsApps\microsoft.d3dmappinglayers_1.2409.2.0_arm64__8wekyb3d8bbwe\dzn_icd.x64.json.  Skipping this file.
WARNING: [Loader Message] Code 0 : loader_add_layer_properties: Can not find 'layer' object in manifest JSON file C:\Program Files\WindowsApps\microsoft.d3dmappinglayers_1.2409.2.0_arm64__8wekyb3d8bbwe\dzn_icd.x86.json.  Skipping this file.
WARNING: [Loader Message] Code 0 : loader_parse_icd_manifest: Can not find 'ICD' object in ICD JSON file C:\Program Files\WindowsApps\microsoft.d3dmappinglayers_1.2409.2.0_arm64__8wekyb3d8bbwe\dzn_layer.arm64.json. Skipping ICD JSON
WARNING: [Loader Message] Code 0 : loader_parse_icd_manifest: Can not find 'ICD' object in ICD JSON file C:\Program Files\WindowsApps\microsoft.d3dmappinglayers_1.2409.2.0_arm64__8wekyb3d8bbwe\dzn_layer.x64.json. Skipping ICD JSON
WARNING: [Loader Message] Code 0 : loader_parse_icd_manifest: Can not find 'ICD' object in ICD JSON file C:\Program Files\WindowsApps\microsoft.d3dmappinglayers_1.2409.2.0_arm64__8wekyb3d8bbwe\dzn_layer.x86.json. Skipping ICD JSON

The warnings alarmingly imply that each file is in fact being skipped, when in actuality the layer files were correctly loaded as layers (and skipped only when being considered as ICDs), and the ICD files were correctly loaded as ICDs (and skipped only when being considered as layers).

It would be less concerning and more accurate to only print a warning for a manifest that contained neither a layer nor an ICD field.

@lunarpapillo lunarpapillo changed the title remove unnnecessary/misleading ICD/layer warnings remove misleading ICD/layer warnings Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant