Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate required dedicated allocations #9087

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Validate required dedicated allocations #9087

wants to merge 3 commits into from

Conversation

ziga-lunarg
Copy link
Contributor

Closes #9083

@ziga-lunarg ziga-lunarg requested a review from a team as a code owner December 22, 2024 16:40
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 330478.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18423 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 330494.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18424 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18424 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 330530.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18425 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18425 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 330576.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18426 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18426 failed.

spencer-lunarg
spencer-lunarg reviewed Dec 23, 2024
View reviewed changes
layers/core_checks/cc_device_memory.cpp
} else if (memory_dedicated_allocate_info->image != bind_info.image) {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError(
vuid, objlist, loc.pNext(Struct::VkMemoryDedicatedAllocateInfo, Field::pNext).dot(Field::image),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the VkMemoryDedicatedAllocateInfo is not part of the location of the caller, so just flip this, so something like

LogError(vuid, objlist, loc.dot(Feild::buffer), "is %s, but the memory was created with a VkMemoryDedicatedAllocateInfo::buffer of %s.",
                    FormatHandle(buffer).c_str(),
                    FormatHandle(memory_dedicated_allocate_info->buffer).c_str());

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, mixed this up with the buffer one above, but comment applies to both

spencer-lunarg
spencer-lunarg reviewed Dec 23, 2024
View reviewed changes
layers/core_checks/cc_device_memory.cpp Outdated
if (!memory_dedicated_allocate_info) {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |=
LogError(vuid, objlist, loc.dot(Field::pNext),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loc.dot(Field::pNext) is wrong, it is lot.dot(Field::memory), "%s was created without an VkMemoryDedicatedAllocateInfo pNext chain"

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 331529.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18428 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18428 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 331583.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18429 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18429 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 331604.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18430 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18430 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 331657.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18432 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18432 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 332646.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18449 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18449 failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencer-lunarg spencer-lunarg spencer-lunarg left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing VK_KHR_dedicated_allocation VUs
3 participants
@ziga-lunarg @ci-tester-lunarg @spencer-lunarg