Add missing swapchain maintenance validation #9107
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 333769. |
|
CI Vulkan-ValidationLayers build # 18467 running. |
ziga-lunarg
force-pushed
the
ziga-issue-9099
branch
from
772e5c7 to
e26b410
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 333786. |
|
CI Vulkan-ValidationLayers build # 18468 running. |
|
CI Vulkan-ValidationLayers build # 18468 failed. |
layers/core_checks/cc_wsi.cpp
Outdated
| @@ -883,7 +885,24 @@ bool CoreChecks::PreCallValidateQueuePresentKHR(VkQueue queue, const VkPresentIn | |||
| "image on queue that cannot present to this surface."); | |||
| } | |||
| } | |||
|
|
|||
| const auto *present_modes = vku::FindStructInPNextChain<VkSwapchainPresentModesCreateInfoEXT>(swapchain_data->create_info.pNext); | |||
| if (present_modes) { | |||
There was a problem hiding this comment.
| if (present_modes) { | |
| if (vku::FindStructInPNextChain<VkSwapchainPresentModesCreateInfoEXT>(swapchain_data->create_info.pNext)) { |
layers/stateless/sl_wsi.cpp
Outdated
| @@ -118,6 +118,56 @@ bool StatelessValidation::ValidateSwapchainCreateInfo(const VkSwapchainCreateInf | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| if (vku::FindStructInPNextChain<VkSwapchainPresentModesCreateInfoEXT>(create_info.pNext) && | |||
There was a problem hiding this comment.
make a new function (ValidateSwapchainCreateInfoMaintenance1) for these (to better group them together) and inside you can just go
if (!enabled_features.swapchainMaintenance1) return skip;
once
ziga-lunarg
force-pushed
the
ziga-issue-9099
branch
from
e26b410 to
a55ca57
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 336756. |
|
CI Vulkan-ValidationLayers build # 18499 running. |
|
CI Vulkan-ValidationLayers build # 18499 failed. |
ziga-lunarg
force-pushed
the
ziga-issue-9099
branch
from
a55ca57 to
db2e303
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 336815. |
|
CI Vulkan-ValidationLayers build # 18502 running. |
|
CI Vulkan-ValidationLayers build # 18502 failed. |
Closes #9099