Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper VK_RENDERING_RESUMING_BIT support with Query #9196

Open
spencer-lunarg opened this issue Jan 10, 2025 · 0 comments
Open

Proper VK_RENDERING_RESUMING_BIT support with Query #9196

spencer-lunarg opened this issue Jan 10, 2025 · 0 comments
Labels
Bug Something isn't working

Comments

@spencer-lunarg
Copy link
Contributor

(from https://gitlab.khronos.org/vulkan/vulkan/-/issues/4137)

VK_RENDERING_RESUMING_BIT should prevent VUs like 07007 from occurring

by going

    m_command_buffer.Begin();
    vk::CmdBeginQuery(m_command_buffer.handle(), query_pool.handle(), 0, 0);
    
    begin_rendering_info.flags = VK_RENDERING_RESUMING_BIT;
    m_command_buffer.BeginRendering(begin_rendering_info);
    
    vk::CmdEndQuery(m_command_buffer.handle(), query_pool.handle(), 0);
    
    m_command_buffer.EndRendering();
    m_command_buffer.End();

we should be able to reach things like VUID-vkCmdEndQuery-queryPool-03228 without triggering 07007


There might be many other spots not accounting for VK_RENDERING_RESUMING_BIT as well

@spencer-lunarg spencer-lunarg added the Bug Something isn't working label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant